[GitHub] [nuttx] jlaitine commented on a diff in pull request #8026: Add mm map

[GitBox]

jlaitine commented on code in PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061509569


##########
include/nuttx/mm/map.h:
##########
@@ -43,7 +49,11 @@ struct mm_map_entry_s
   off_t offset;
   int prot;
   int flags;
-  FAR void *priv;
+  union
+  {
+    FAR void *p;
+    int i;

Review Comment:
   I think it is, in general, a good idea to include some target which forces 
using C89 into CI.
   
   I am myself not that pedantic about that, as long as all the supported 
boards compile with the respective compilers, we should be good.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org