jlaitine commented on code in PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#discussion_r1062159098
##########
include/nuttx/mm/map.h:
##########
@@ -43,7 +49,11 @@ struct mm_map_entry_s
off_t offset;
int prot;
int flags;
- FAR void *priv;
+ union
+ {
+ FAR void *p;
+ int i;
Review Comment:
I measured the difference to have it always included on nucleo-f091rc:nsh
With mapping code always included the size is 40612 bytes, and without it is
40492 bytes. The difference is just 120 bytes in code, which originates from
fs_mumap.c.
So I think it is ok to remove the flag and have it always included. Will do
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
