acassis commented on code in PR #8047:
URL: https://github.com/apache/nuttx/pull/8047#discussion_r1063538058
##########
arch/xtensa/src/esp32/Kconfig:
##########
@@ -1158,6 +1158,37 @@ config ESP32_SPI2_MISOPIN
default 12
range 0 39
+choice ESP32_SPI2_MASTER_IO
+ prompt "SPI2 master I/O mode"
+ default ESP32_SPI2_MASTER_IO_RW
Review Comment:
Should it have a "depends on !SPI_SLAVE" ? Otherwise the user could select
the ESP32_SPI2_MASTER_IO even when SPI_SLAVE is enabled
##########
arch/xtensa/src/esp32/Kconfig:
##########
@@ -1182,6 +1213,37 @@ config ESP32_SPI3_MISOPIN
default 19
range 0 39
+choice ESP32_SPI3_MASTER_IO
+ prompt "SPI3 master I/O mode"
+ default ESP32_SPI3_MASTER_IO_RW
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
