xiaoxiang781216 commented on code in PR #8047:
URL: https://github.com/apache/nuttx/pull/8047#discussion_r1065006792
##########
arch/xtensa/src/esp32/Kconfig:
##########
@@ -1158,6 +1158,37 @@ config ESP32_SPI2_MISOPIN
default 12
range 0 39
+choice ESP32_SPI2_MASTER_IO
+ prompt "SPI2 master I/O mode"
+ default ESP32_SPI2_MASTER_IO_RW
Review Comment:
but the current design allow use select ESP32_SPI2_MASTER_IO_RW and
ESP32_SPI2_SLAVE_IO_RW, which looks wrong. You should merge
ESP32_SPI2_MASTER_IO_RW and ESP32_SPI2_SLAVE_IO_RW into one choice to avoid the
invalid combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
