acassis commented on PR #8304: URL: https://github.com/apache/nuttx/pull/8304#issuecomment-1406952132
> > @dvosahlik you cannot add NET_CAN_HAVE_ERRORS for each chip, it depends on Socket CAN enabled for that chip, please take a look at STM32_CAN_SOCKET and STM32_FDCAN_SOCKET to see how it is done on STM32 > > @acassis I added that for all the tiva chips, that have CAN peripheral and for which the SocketCAN is implemented in this PR. Yes, but NET_CAN_HAVE_ERRORS only exist when users enable the CAN. The chip itself having CAN doesn't imply that users will enable it. So, it should be enabled by TIVA_CAN, not by the chip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
