centurysys commented on code in PR #8510: URL: https://github.com/apache/nuttx/pull/8510#discussion_r1103743552
########## arch/arm/src/common/Toolchain.defs: ########## @@ -316,7 +316,7 @@ endif EXTRA_LIBS += $(COMPILER_RT_LIB) -ifneq ($(CONFIG_LIBM),y) +ifeq ($(CONFIG_LIBM),y) EXTRA_LIBS += $(wildcard $(shell $(CC) $(ARCHCPUFLAGS) --print-file-name=libm.a)) Review Comment: There are so many references to "CONFIG_LIBM", it might be better to rename it as "CONFIG_LIBM_BUILTIN". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
