gustavonihei commented on code in PR #1649: URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1131100578
########## testing/ostest/suspend.c: ########## @@ -22,14 +22,18 @@ * Included Files ****************************************************************************/ -#include <sys/types.h> +#include <nuttx/config.h> + +#include <errno.h> +#include <pthread.h> +#include <sched.h> +#include <semaphore.h> +#include <signal.h> #include <stdbool.h> #include <stdio.h> #include <unistd.h> -#include <semaphore.h> -#include <signal.h> -#include <sched.h> -#include <errno.h> +#include <sys/types.h> Review Comment: `sys/types.h` is most probably required due to `size_t`, but I agree that there might be some cases where it is needlessly being included. In this current endeavor I am just trying to make #8744 pass the CI by including the missing headers. Later we could use a tool-assisted method (e.g. [IWYU](https://include-what-you-use.org/)) to remove unused headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
