gustavonihei commented on code in PR #1649: URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1136261494
########## system/nxlooper/nxlooper.c: ########## @@ -24,21 +24,21 @@ #include <nuttx/config.h> -#include <sys/param.h> -#include <sys/types.h> -#include <sys/ioctl.h> - -#include <stdint.h> +#include <assert.h> +#include <debug.h> +#include <dirent.h> +#include <errno.h> +#include <fcntl.h> +#include <sched.h> #include <stdbool.h> +#include <stdint.h> #include <stdio.h> +#include <stdlib.h> #include <string.h> Review Comment: Even though NuttX coding standard imposes no restrictions or rules on this, I usually like to follow Google's C Style guide, in this case specifically the [Include What You Use guideline](https://google.github.io/styleguide/cppguide.html#Include_What_You_Use). It is better to be pedantic and include everything that is being referenced than to rely on transitive inclusions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
