xiaoxiang781216 commented on code in PR #8843:
URL: https://github.com/apache/nuttx/pull/8843#discussion_r1141420320
##########
drivers/usbdev/cdcacm.c:
##########
@@ -2339,9 +2339,6 @@ static int cdcuart_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
/* And update with flags from this layer */
- termiosp->c_iflag = serdev->tc_iflag;
- termiosp->c_oflag = serdev->tc_oflag;
- termiosp->c_lflag = serdev->tc_lflag;
Review Comment:
The code can be removed safely since the common code in serial.c already
handle them correctly:
https://github.com/apache/nuttx/blob/master/drivers/serial/serial.c#L1556-L1601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
