xiaoxiang781216 commented on code in PR #8843:
URL: https://github.com/apache/nuttx/pull/8843#discussion_r1141424238
##########
drivers/usbdev/cdcacm.c:
##########
@@ -2339,9 +2339,6 @@ static int cdcuart_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
/* And update with flags from this layer */
- termiosp->c_iflag = serdev->tc_iflag;
- termiosp->c_oflag = serdev->tc_oflag;
- termiosp->c_lflag = serdev->tc_lflag;
Review Comment:
> These flags are saved in the TCSETS ioctl logic, but never referenced
elsewhere. Should they be removed from that location as well? Should they be
removed from the uart_dev_s structure? Does anything use them?
tc_iflag/tc_oflag/tc_lflag is used in serial.c to guard the various terminal
special process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
