gustavonihei commented on code in PR #8823: URL: https://github.com/apache/nuttx/pull/8823#discussion_r1143719414
########## sched/mqueue/mq_send.c: ########## @@ -22,18 +22,18 @@ * Included Files ****************************************************************************/ -#include <nuttx/config.h> - -#include <sys/types.h> -#include <mqueue.h> -#include <errno.h> -#include <debug.h> - -#include <nuttx/irq.h> -#include <nuttx/arch.h> -#include <nuttx/cancelpt.h> - -#include "mqueue/mqueue.h" +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/cancelpt.h> +#include <nuttx/irq.h> Review Comment: In my opinion these (with the exception of `nuttx/config.h`) could be left in their current placement, after the C system headers. But since the include order is not enforced by the NuttX coding standard, I won't block the PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
