pkarashchenko commented on code in PR #8878:
URL: https://github.com/apache/nuttx/pull/8878#discussion_r1146794275
##########
include/assert.h:
##########
@@ -66,20 +66,20 @@
} \
while (0)
#else
-# define ASSERT(f) \
- do \
- { \
- if (predict_false(!(f))) \
- __assert(__FILE__, __LINE__, NULL); \
- } \
+# define ASSERT(f) \
+ do \
+ { \
+ if (predict_false(!(f))) \
+ __assert(__FILE__, __LINE__, 0); \
Review Comment:
Ok. I just checked. The parameter values are not checked. I was thinking
that `-Wint-conversion` will catch it, but seems it handles only direct
assignment cases (and passing a parameter is a kind of indirect assignment, so
strange why this is not caught).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
