acassis commented on PR #8913: URL: https://github.com/apache/nuttx/pull/8913#issuecomment-1486879938
> > Note that nxsig_timedwait and nxsig_procmask alone represent almost 50% of increase, maybe these could be the functions to investigate. > > The three biggest increases in function size, is inexplicable. There is a very small change to each function but the expansion of the funciton size is large. Something else is going on. One would probably have to look at when the linker is doing in the disassembly. Here are the code changes: > > * Added three functioin calls to nxsig_timedwait: [717bb04#diff-c610905678f957e3a394e88cfca1d9c97fc98017d9f5d4103d2707d07883b463](https://github.com/apache/nuttx/commit/717bb04cb7c6f1efb179d40a464e43e7cd13c7d8#diff-c610905678f957e3a394e88cfca1d9c97fc98017d9f5d4103d2707d07883b463) > > * Added one function call to nxsig_procmask: [717bb04#diff-9688e7f9a0a4d148691d3ab31ac7ebaa2df66c89270533ff21fbb9f969082948](https://github.com/apache/nuttx/commit/717bb04cb7c6f1efb179d40a464e43e7cd13c7d8#diff-9688e7f9a0a4d148691d3ab31ac7ebaa2df66c89270533ff21fbb9f969082948) Also many options that had a CONFIG flag to enable/disable were removed to force the kernel to become more POSIX compatible. An alternative could be having a flag CONFIG_NON_POSIX_COMPLIANT to allow disable some of these features (like the increased number of signals), this way we could have NuttX running again on MCUs with 32KB Flash for example. Maybe in this case a NuttShell banner saying "Not POSIX Compliant" could be printed to warn the user. Just some ideas, but of course, if we could keep the functionalities and just optimize the code to reduce the flash size, it will be much better! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
