zyfeier commented on code in PR #8876: URL: https://github.com/apache/nuttx/pull/8876#discussion_r1169454949
########## arch/arm64/src/common/arm64_boot.c: ########## @@ -100,26 +106,28 @@ void arm64_boot_el2_init(void) { uint64_t reg; - reg = read_sysreg(sctlr_el2); - reg |= (SCTLR_EL2_RES1 | /* RES1 */ - SCTLR_I_BIT | /* Enable i-cache */ - SCTLR_SA_BIT); /* Enable SP alignment check */ + reg = read_sysreg(sctlr_el2); + reg |= (SCTLR_EL2_RES1 | /* RES1 */ +#ifndef CONFIG_ARM64_ICACHE_DISABLE Review Comment: @pkarashchenko I have deleted the third commit and will resubmit it after I come up with a more appropriate modification. Please help review the current two commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org