masayuki2009 commented on code in PR #9026:
URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173219898
##########
arch/arm/src/imx6/imx_enet.c:
##########
@@ -200,6 +201,16 @@
# define BOARD_PHY_10BASET(s) (((s) & MII_DP83825I_PHYSTS_SPEED) != 0)
# define BOARD_PHY_100BASET(s) (((s) & MII_DP83825I_PHYSTS_SPEED) == 0)
# define BOARD_PHY_ISDUPLEX(s) (((s) & MII_DP83825I_PHYSTS_DUPLEX) != 0)
+#elif defined(CONFIG_ETH0_PHY_AR8031)
+# define BOARD_PHY_NAME "AR8031"
+# define BOARD_PHYID1 MII_PHYID1_AR8031
+# define BOARD_PHYID2 MII_PHYID2_AR8031
+# define BOARD_PHY_STATUS MII_AR8031_PSSR
+# define BOARD_PHY_ADDR (1)
+# define BOARD_PHY_10BASET(s) (((s)&MII_AR8031_PSSR_10MBPS) ==
((s)&MII_AR8031_PSSR_SPEEDMASK))
+# define BOARD_PHY_100BASET(s) (((s)&MII_AR8031_PSSR_100MBPS) ==
((s)&MII_AR8031_PSSR_SPEEDMASK))
+# define BOARD_PHY_1000BASET(s) (((s)&MII_AR8031_PSSR_1000MBPS) ==
((s)&MII_AR8031_PSSR_SPEEDMASK))
+# define BOARD_PHY_ISDUPLEX(s) (((s)&MII_AR8031_PSSR_DUPLEX) != 0)
Review Comment:
Done.
##########
arch/arm/src/imx6/imx_enet.c:
##########
@@ -2258,10 +2292,10 @@ static inline int imx_initphy(struct imx_driver_s
*priv, bool renogphy)
<< ENET_RCR_MAX_FL_SHIFT |
ENET_RCR_MII_MODE;
#else
- rcr = ENET_RCR_RMII_MODE | ENET_RCR_CRCFWD |
+ rcr = ENET_RCR_CRCFWD |
(CONFIG_NET_ETH_PKTSIZE + CONFIG_NET_GUARDSIZE)
<< ENET_RCR_MAX_FL_SHIFT |
- ENET_RCR_MII_MODE;
+ ENET_RCR_RGMII_EN;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
