pkarashchenko commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173586696
########## arch/arm/src/imx6/imx_enet.c: ########## @@ -2252,16 +2285,13 @@ static inline int imx_initphy(struct imx_driver_s *priv, bool renogphy) * configuration and the auto negotiation results. */ -#ifdef CONFIG_IMX_ENETUSEMII rcr = ENET_RCR_CRCFWD | (CONFIG_NET_ETH_PKTSIZE + CONFIG_NET_GUARDSIZE) << ENET_RCR_MAX_FL_SHIFT | +#ifdef CONFIG_IMX_ENETUSEMII ENET_RCR_MII_MODE; #else - rcr = ENET_RCR_RMII_MODE | ENET_RCR_CRCFWD | - (CONFIG_NET_ETH_PKTSIZE + CONFIG_NET_GUARDSIZE) - << ENET_RCR_MAX_FL_SHIFT | - ENET_RCR_MII_MODE; + ENET_RCR_RGMII_EN; Review Comment: Why `ENET_RCR_RMII_MODE` is dropped? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org