zhhyu7 commented on code in PR #9058: URL: https://github.com/apache/nuttx/pull/9058#discussion_r1173659537
########## include/net/ethernet.h: ########## @@ -33,6 +33,10 @@ #define ETHER_ADDR_LEN 6 +#define ETHERTYPE_ARP 0x0806 /* Address resolution protocol */ +#define ETHERTYPE_IP 0x0800 /* IP */ +#define ETHERTYPE_IPV6 0x86dd /* IP protocol version 6 */ Review Comment: glibc and musl both define ETHERTYPE_*, so many applications use this definition, and if we compile directly in NuttX's environment, we will get a compile error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
