hartmannathan commented on code in PR #9058: URL: https://github.com/apache/nuttx/pull/9058#discussion_r1173864014
########## include/net/ethernet.h: ########## @@ -33,6 +33,10 @@ #define ETHER_ADDR_LEN 6 +#define ETHERTYPE_ARP 0x0806 /* Address resolution protocol */ +#define ETHERTYPE_IP 0x0800 /* IP */ +#define ETHERTYPE_IPV6 0x86dd /* IP protocol version 6 */ Review Comment: Another idea: With Kconfig, developers could select: NuttX POSIX-only, Linux-style, and/or BSD-style. These would not be mutually exclusive; that is, you could select more than one. Those selection(s) would enable/disable things like glibc-style declarations. Two disadvantages of this idea: (1) more Kconfig/ifdef in the codebase, (2) how do we handle cases where Linux-style and BSD-style conflict with each other? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
