xiaoxiang781216 commented on code in PR #1755:
URL: https://github.com/apache/nuttx-apps/pull/1755#discussion_r1194096997


##########
nshlib/nsh_session.c:
##########
@@ -169,6 +170,21 @@ int nsh_session(FAR struct console_stdio_s *pstate,
         }
     }
 
+#if CONFIG_NSH_DISABLE_ECHOBACK

Review Comment:
   please ingore my suggestoin, look like the code before the change never 
reads from /dev/console



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to