pkarashchenko commented on code in PR #1755:
URL: https://github.com/apache/nuttx-apps/pull/1755#discussion_r1196961489
##########
nshlib/nsh_session.c:
##########
@@ -169,6 +170,21 @@ int nsh_session(FAR struct console_stdio_s *pstate,
}
}
+#if CONFIG_NSH_DISABLE_ECHOBACK
+ /* Disable echoback */
+
+ struct termios cfg;
+
+ if (isatty(INFD(pstate)))
+ {
+ if (tcgetattr(INFD(pstate), &cfg) == 0)
Review Comment:
```suggestion
if (isatty(INFD(pstate)))
{
struct termios cfg;
if (tcgetattr(INFD(pstate), &cfg) == 0)
```
##########
nshlib/nsh_session.c:
##########
@@ -169,6 +170,21 @@ int nsh_session(FAR struct console_stdio_s *pstate,
}
}
+#if CONFIG_NSH_DISABLE_ECHOBACK
Review Comment:
```suggestion
#ifdef CONFIG_NSH_DISABLE_ECHOBACK
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
