xiaoxiang781216 commented on code in PR #9304:
URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195857955
##########
boards/arm64/a64/pinephone/Kconfig:
##########
@@ -17,4 +17,10 @@ config PINEPHONE_LCD
---help---
Select to enable support for LCD Display.
+config PINEPHONE_MODEM
+ bool "LTE Modem"
+ default n
+ ---help---
+ Select to enable support for Quectel EG25-G LTE Modem.
Review Comment:
Can we abstract a modem interface? So, the SoC can support the different
modem, and the modem can support different SoC.
##########
Documentation/platforms/arm/a64/boards/pinephone/index.rst:
##########
@@ -155,6 +155,13 @@ Supports all the features in ``lcd``,
plus LVGL Graphics Library and Touch Panel (GT917S).
Serial Console is enabled on UART0 at 115.2 kbps.
+modem
+-----
+
+Supports LTE Modem (EG25-G). Accepts AT Commands on UART3
+at ``/dev/ttyS1``.
Review Comment:
should we make /dev/ttySx match the datasheet number(UARTx)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
