lupyuen commented on code in PR #9304:
URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195862416


##########
Documentation/platforms/arm/a64/boards/pinephone/index.rst:
##########
@@ -155,6 +155,13 @@ Supports all the features in ``lcd``,
 plus LVGL Graphics Library and Touch Panel (GT917S).
 Serial Console is enabled on UART0 at 115.2 kbps.
 
+modem
+-----
+
+Supports LTE Modem (EG25-G). Accepts AT Commands on UART3
+at ``/dev/ttyS1``.

Review Comment:
   Unfortunately UARTx won't match ttySx on PinePhone. Here are the upcoming 
UART ports:
   
   - UART0 (ttyS0): Serial Console
   - UART1 (ttyS1): Bluetooth Module (Realtek RTL8723CS, not integrated with 
NuttX yet)
   - UART2: Unused, wired to Light Sensor and Compass Sensor
   - UART3 (ttyS2): LTE Modem (Quectel EG25-G, integrated with NuttX)
   
   [More details 
here](https://lupyuen.github.io/articles/serial#appendix-uart-ports-on-pinephone)
   
   I could modify `modem/defconfig` to enable UART1 on ttyS1 (Bluetooth). But 
UART3 will always map to ttyS2 (LTE Modem) because UART2 is unused.
   
   Shall I make this change? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to