tmedicci commented on code in PR #9404: URL: https://github.com/apache/nuttx/pull/9404#discussion_r1208585299
########## arch/xtensa/src/common/xtensa_nputs.c: ########## @@ -39,8 +40,14 @@ void up_nputs(const char *str, size_t len) Review Comment: > since up_putc can be called in the interrupt context, and up_nputs is an accelerated version of up_putc, it's better to make up_nputc work in the interrupt handler too. Do you mean `up_nputs`? I don't know if we should consider it to be used in the interrupt handler. Instead of using a mutex (and making it work in ISRs), I can only think of protecting it with `spin_lock_irqsave`, but it'd deteriorate general performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
