tmedicci commented on code in PR #9404: URL: https://github.com/apache/nuttx/pull/9404#discussion_r1210182246
########## arch/xtensa/src/common/xtensa_nputs.c: ########## @@ -39,8 +40,14 @@ void up_nputs(const char *str, size_t len) Review Comment: @xiaoxiang781216 , I was thinking about https://github.com/apache/nuttx/pull/6618/commits/1a048f8ff703faa37e89f30f4775f32ef3829505 (from #6618): Could it be reverted (or a mutex be added there)? If syslog is called from the interrupt handler, it won't end up calling `syslog_default_write` (it'd use the registered `sc_force` instead, which is `syslog_default_putc`. By doing that, we can avoid creating a "thread-safe" version of `up_nputs`. What do you think about it? It solves this same issue from an upper level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
