xiaoxiang781216 commented on code in PR #9400:
URL: https://github.com/apache/nuttx/pull/9400#discussion_r1212016813
##########
tools/configure.c:
##########
@@ -1590,6 +1590,48 @@ static void refresh(void)
}
}
+static void generate_info()
+{
+ /* Append the configuration information to the .info file */
+
+ FILE *stream;
+ char *tmp_boarddir;
+
+ snprintf(g_buffer, BUFFER_SIZE, "%s%c%s", g_topdir, g_delim, ".info");
+ stream = fopen(g_buffer, "w");
+ if (!stream)
+ {
+ fprintf(stderr,
+ "ERROR: Failed to open %s for write mode: %s\n",
+ g_buffer, strerror(errno));
+ exit(EXIT_FAILURE);
+ }
+
+ tmp_boarddir = double_appdir_backslashes(g_boarddir);
+ if (NULL == tmp_boarddir)
+ {
+ fprintf(stderr,
+ "ERROR: Failed to double boarddir backslashes\n");
+ exit(EXIT_FAILURE);
+ }
+
+ fprintf(stream, "CONFIG_BASE_DEFCONFIG=\"%s\"\n", tmp_boarddir);
Review Comment:
so .info just contain CONFIG_BASE_DEFCONFIG? why not append to .config
directly?
##########
tools/configure.sh:
##########
@@ -307,3 +309,12 @@ fi
# reconstitued before they can be used.
${TOPDIR}/tools/sethost.sh $host $*
+
+# Update the CONFIG_BASE_DEFCONFIG setting in the .info file
+
+posboardconfig=`echo "${boardconfig}" | sed -e 's/\\\\/\\//g'`
+echo "CONFIG_BASE_DEFCONFIG=\"$posboardconfig\"" > "${info_file}"
+
+# Save the original configuration file for later comparison
Review Comment:
why need save the original config file if we already have .config and
.config.old?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
