patacongo commented on code in PR #9400: URL: https://github.com/apache/nuttx/pull/9400#discussion_r1212042703
########## tools/configure.c: ########## @@ -1590,6 +1590,48 @@ static void refresh(void) } } +static void generate_info() +{ + /* Append the configuration information to the .info file */ + + FILE *stream; + char *tmp_boarddir; + + snprintf(g_buffer, BUFFER_SIZE, "%s%c%s", g_topdir, g_delim, ".info"); + stream = fopen(g_buffer, "w"); + if (!stream) + { + fprintf(stderr, + "ERROR: Failed to open %s for write mode: %s\n", + g_buffer, strerror(errno)); + exit(EXIT_FAILURE); + } + + tmp_boarddir = double_appdir_backslashes(g_boarddir); + if (NULL == tmp_boarddir) + { + fprintf(stderr, + "ERROR: Failed to double boarddir backslashes\n"); + exit(EXIT_FAILURE); + } + + fprintf(stream, "CONFIG_BASE_DEFCONFIG=\"%s\"\n", tmp_boarddir); Review Comment: configure.sh already appends settings to .config. It is a standard practice to do this. You would need to have a definition in a Kconfig file, but only to prevent the appended setting from being lost if re-configured. Like: config BASE_DEFCONFIG string default "" It does not have to have a value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org