raiden00pl commented on code in PR #1872: URL: https://github.com/apache/nuttx-apps/pull/1872#discussion_r1279058490
########## system/ofloader/segger.c: ########## @@ -0,0 +1,244 @@ +/**************************************************************************** + * apps/system/ofloader/segger.c Review Comment: Maybe it's worth moving the whole `ofloader` to the kernel side ? Is it foreseen that the `ofloader` will be run from NSH? or only as an entry point? If we want to keep it in apps then we should use `boardctl` interface to call `__start`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
