xiaoxiang781216 commented on code in PR #1872: URL: https://github.com/apache/nuttx-apps/pull/1872#discussion_r1279540460
########## system/ofloader/segger.c: ########## @@ -0,0 +1,244 @@ +/**************************************************************************** + * apps/system/ofloader/segger.c Review Comment: Sure, ofloader is designed to work in bootloader, and most bootloader is built with flat mode to make it as simple as possible, so the limitation here isn't too rigid as the first glance. ########## system/ofloader/segger.c: ########## @@ -0,0 +1,244 @@ +/**************************************************************************** + * apps/system/ofloader/segger.c Review Comment: Yes, it isn't good to call __start from app, but since ofloader is a very low-level tool which interact JLINK directly: 1. JLINK require flash programmer must start with SEGGER_FL_Prepare in PrgData section 2. ofloader is designed to work only in FLAT mode, it can call __start without trouble Do you have the better idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
