acassis commented on code in PR #10380:
URL: https://github.com/apache/nuttx/pull/10380#discussion_r1310768940
##########
binfmt/binfmt_exec.c:
##########
@@ -37,11 +37,103 @@
#ifndef CONFIG_BINFMT_DISABLE
/****************************************************************************
- * Public Functions
+ * Internel Functions
****************************************************************************/
/****************************************************************************
- * Name: exec_spawn
+ * Name: update_attr
+ *
+ * Description:
+ * Update the bin spawn attribute.
+ *
+ * Input Parameters:
+ * bin - The binrary information.
+ * attr - The spawn attributes.
+ *
+ * Returned Value:
+ * none
+ *
+ ****************************************************************************/
+
+static inline void update_attr(FAR struct binary_s *bin,
+ FAR const posix_spawnattr_t *attr)
+{
+ if (bin && attr)
Review Comment:
I think it should be more legible if you use:
if (bin != NULL && attr != NULL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
