xiaoxiang781216 commented on code in PR #10380:
URL: https://github.com/apache/nuttx/pull/10380#discussion_r1325431458
##########
binfmt/binfmt_exec.c:
##########
@@ -64,17 +64,20 @@
* nexports - The number of symbols in the exports table.
* actions - The spawn file actions
* attr - The spawn attributes.
+ * spawn - Is spawn in new task.
*
* Returned Value:
* It returns the PID of the exec'ed module. On failure, it returns
* the negative errno value appropriately.
*
****************************************************************************/
-int exec_spawn(FAR const char *filename, FAR char * const *argv,
- FAR char * const *envp, FAR const struct symtab_s *exports,
- int nexports, FAR const posix_spawn_file_actions_t *actions,
- FAR const posix_spawnattr_t *attr)
+int exec_internel(FAR const char *filename, FAR char * const *argv,
+ FAR char * const *envp,
Review Comment:
```suggestion
FAR char * const *argv, FAR char * const *envp,
```
##########
binfmt/binfmt_exec.c:
##########
@@ -64,17 +64,20 @@
* nexports - The number of symbols in the exports table.
* actions - The spawn file actions
* attr - The spawn attributes.
+ * spawn - Is spawn in new task.
*
* Returned Value:
* It returns the PID of the exec'ed module. On failure, it returns
* the negative errno value appropriately.
*
****************************************************************************/
-int exec_spawn(FAR const char *filename, FAR char * const *argv,
- FAR char * const *envp, FAR const struct symtab_s *exports,
- int nexports, FAR const posix_spawn_file_actions_t *actions,
- FAR const posix_spawnattr_t *attr)
+int exec_internel(FAR const char *filename, FAR char * const *argv,
+ FAR char * const *envp,
+ FAR const struct symtab_s *exports,
Review Comment:
```suggestion
FAR const struct symtab_s *exports, int nexports,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
