masayuki2009 commented on PR #10470: URL: https://github.com/apache/nuttx/pull/10470#issuecomment-1707603504
@nealef Please `git rebase -i HEAD~4` to fixup the commits into one commit. ``` commit 4c925d0a322e1f5427f3e63e7ebbbb711b8b2d10 (HEAD -> dynload-fix, origin/dynload-fix) Author: Neale Ferguson <[email protected]> Date: Wed Sep 6 13:26:15 2023 +1000 Style fix and avoid a compiler warning * libs/libc/modlib/modlib_bind.c - Style - Avoid compiler warning for a situation that won't happen * libs/libc/sched/module/mod_rmmod.c - Style commit c31999cd49ed2e79901d115e0cfd9ac267f6fd99 Author: Neale Ferguson <[email protected]> Date: Wed Sep 6 12:49:43 2023 +1000 Revert some style fixes as block comments aren't what the style guide implies commit 3f9cf64fb448dbf09d249e2e737c180388b494b7 Author: Neale Ferguson <[email protected]> Date: Wed Sep 6 12:28:36 2023 +1000 Further style fixes * libs/libc/dlfcn/lib_dlclose.c libs/libc/modlib/modlib_bind.c libs/libc/modlib/modlib_load.c libs/libc/modlib/modlib_unload.c sched/module/mod_rmmod.c commit 38222bfc2fdd5eaf147dc7e2acee4b076d9909a4 Author: Neale Ferguson <[email protected]> Date: Wed Sep 6 12:03:09 2023 +1000 Stle updates * libs/libc/dlfcn/lib_dlclose.c libs/libc/modlib/modlib_bind.c libs/libc/modlib/modlib_load.c libs/libc/modlib/modlib_unload.c sched/module/mod_rmmod.c - Fixes to conform to style guide: - Brace alignment - Indentations - Danlging white space - Comments ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
