pkarashchenko commented on code in PR #10470:
URL: https://github.com/apache/nuttx/pull/10470#discussion_r1327638045
##########
libs/libc/modlib/modlib_globals.S:
##########
@@ -54,20 +49,20 @@
.arch armv8-m.base
#endif
#ifdef __ARM_ASM_SYNTAX_UNIFIED__
- .syntax unified
+ .syntax unified
#endif
.thumb
#endif
.data
.align ALIGN
- GLOBAL globalNames
+ GLOBAL globalNames
SYMBOL(globalNames):
- SIZE globalNames
+ SIZE globalNames
Review Comment:
```suggestion
SIZE globalNames
```
##########
libs/libc/modlib/modlib_globals.S:
##########
@@ -54,20 +49,20 @@
.arch armv8-m.base
#endif
#ifdef __ARM_ASM_SYNTAX_UNIFIED__
- .syntax unified
+ .syntax unified
#endif
.thumb
#endif
.data
.align ALIGN
- GLOBAL globalNames
+ GLOBAL globalNames
SYMBOL(globalNames):
- SIZE globalNames
+ SIZE globalNames
.align ALIGN
GLOBAL nglobals
-SYMBOL(nglobals):
+SYMBOL(nglobals):
Review Comment:
```suggestion
SYMBOL(nglobals):
```
##########
libs/libc/modlib/modlib_globals.S:
##########
@@ -54,20 +49,20 @@
.arch armv8-m.base
#endif
#ifdef __ARM_ASM_SYNTAX_UNIFIED__
- .syntax unified
+ .syntax unified
#endif
.thumb
#endif
.data
.align ALIGN
- GLOBAL globalNames
+ GLOBAL globalNames
Review Comment:
```suggestion
GLOBAL globalNames
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
