spiriou commented on PR #10485: URL: https://github.com/apache/nuttx/pull/10485#issuecomment-1712303979
> > > @spiriou please take a look! > > > > > > I'm not sure to understand how this PR would change the way EP are exposed to apps. I can only see USB descriptors refactoring here. Can you share more details? > > @spiriou the major change is: > > 1. Move the common code to usbdev_fs, so all pass-through driver(e.g. adb, fastboot, mtp) can share the implementation. > 2. Split dev/adb0 to /dev/adb0/ep0 and /dev/adb0/ep1 since many usb driver has more than two data endpoint. I'm not against this change although I feel like a char device with a single file descriptor makes more sense to interact with the ADB device endpoints, compared to 2 (ie. 1 file descriptor for read operations and another one for write operations). The ADB driver is very similar to the CDC ACM in terms of "userspace" interactions. I'll merge the change [https://github.com/spiriou/microADB/pull/36](https://github.com/spiriou/microADB/pull/36) once this PR is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
