acassis commented on code in PR #10840:
URL: https://github.com/apache/nuttx/pull/10840#discussion_r1342906548
##########
include/nuttx/sched_note.h:
##########
@@ -119,6 +119,11 @@
memset((s), 0, sizeof(struct note_filter_tag_s));
#endif
+#define NOTE_BEGINEX_EVENT 0
+#define NOTE_ENDEX_EVENT 1
+#define NOTE_MARK_EVENT 2
+#define NOTE_COUNTER_EVENT 3
Review Comment:
Please align the block!
##########
drivers/note/noteram_driver.c:
##########
@@ -986,14 +986,48 @@ static int noteram_dump_one(FAR uint8_t *p, FAR struct
lib_outstream_s *s,
noteram_dump_unflatten(&ip, nbi->nbi_ip, sizeof(ip));
- ret += lib_sprintf(s, "0x%" PRIdPTR ": event=%u count=%u", ip,
- nbi->nbi_event, count);
- for (i = 0; i < count; i++)
+ switch (nbi->nbi_event)
{
- ret += lib_sprintf(s, " 0x%x", nbi->nbi_data[i]);
- }
-
- ret += lib_sprintf(s, "\n");
+ case NOTE_BEGINEX_EVENT:
+ {
+ ret += lib_sprintf(s, "tracing_mark_write: B|%d|%*s\n", pid,
+ count, nbi->nbi_data);
Review Comment:
```suggestion
count, nbi->nbi_data);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
