xiaoxiang781216 commented on code in PR #10840:
URL: https://github.com/apache/nuttx/pull/10840#discussion_r1350646381
##########
include/nuttx/sched_note.h:
##########
@@ -700,8 +636,7 @@ void sched_note_filter_tag(FAR struct note_filter_tag_s
*oldf,
}
#endif
-#else /* CONFIG_SCHED_INSTRUMENTATION */
-
+#ifndef CONFIG_SCHED_INSTRUMENTATION
Review Comment:
why replace #else with #ifndef
##########
include/nuttx/sched_note.h:
##########
@@ -535,13 +549,24 @@ void sched_note_printf_ip(uint32_t tag, uintptr_t ip,
FAR const char *fmt, ...) printf_like(3, 4);
void sched_note_bprintf_ip(uint32_t tag, uintptr_t ip, uint8_t event,
FAR const char *fmt, ...) printf_like(4, 5);
+
+static void inline sched_note_counter_ip(uint32_t tag, uintptr_t ip,
Review Comment:
why not call shced_note_dump directly
##########
drivers/note/noteram_driver.c:
##########
@@ -973,6 +973,39 @@ static int noteram_dump_one(FAR uint8_t *p, FAR struct
lib_outstream_s *s,
}
break;
+ case NOTE_DUMP_BEGIN:
+ case NOTE_DUMP_END:
+ case NOTE_DUMP_BEGINEX:
+ case NOTE_DUMP_ENDEX:
+ case NOTE_DUMP_MARK:
+ {
+ FAR struct note_binary_s *nbi = (FAR struct note_binary_s *)p;
Review Comment:
remove nbi_event from note_binary_s
##########
include/nuttx/sched_note.h:
##########
@@ -183,6 +184,13 @@ enum note_type_e
NOTE_IRQ_LEAVE = 21,
NOTE_DUMP_STRING = 22,
NOTE_DUMP_BINARY = 23,
+ NOTE_DUMP_BEGIN = 24,
+ NOTE_DUMP_END = 25,
+ NOTE_DUMP_BEGINEX = 26,
Review Comment:
remove NOTE_DUMP_BEGINEX/NOTE_DUMP_ENDEX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
