tmedicci commented on code in PR #10854: URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346275963
########## arch/xtensa/src/esp32s3/esp32s3_ble_adapter.c: ########## @@ -896,7 +960,8 @@ static int IRAM_ATTR semphr_take_from_isr_wrapper(void *semphr, void *hptw) { *(int *)hptw = 0; - return esp_errno_trans(nxsem_trywait(semphr)); + DEBUGPANIC(); Review Comment: Basically, because it isn't needed. We don't expect this function to be called by the BLE driver and we save IRAM space once we don't need to allocate the `nxsem_trywait` implementation there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org