tmedicci commented on code in PR #10854:
URL: https://github.com/apache/nuttx/pull/10854#discussion_r1346343511


##########
arch/xtensa/src/esp32s3/esp32s3_irq.c:
##########
@@ -785,6 +873,15 @@ int esp32s3_setup_irq(int cpu, int periphid, int priority, 
int type)
   intmap[cpuint] = CPUINT_ASSIGN(periphid + XTENSA_IRQ_FIRSTPERIPH);
   g_irqmap[irq] = IRQ_MKMAP(cpu, cpuint);
 
+  if ((flags & ESP32S3_CPUINT_FLAG_IRAM) != 0)
+    {
+      esp32s3_irq_set_iram_isr(irq);
+    }
+  else
+    {
+      esp32s3_irq_unset_iram_isr(irq);

Review Comment:
   Yes, I thought the same, but the meaning is a little bit different from 
set/clear. I thought it would be more like selecting/unselecting, but that 
would be too long...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to