wengzhe commented on PR #11054: URL: https://github.com/apache/nuttx/pull/11054#issuecomment-1794479171
> @wengzhe per @gregory-nutt comment > > > Supporting the second address has size/performance implications and probably should be a Kconfig option. > > What is the size hit on code space for this? Can it be Kconfig-ed out? Hi @davids5, I've tested this PR on `stm32f4discovery:netnsh` and `stm32f4discovery:ipv6`, basically, the configs that don't use IPv6 won't be affected much. On `stm32f4discovery:netnsh`, which only enables `CONFIG_NET_IPv4`, the code size increases 60 Bytes ``` > arm-none-eabi-size stm32-* text data bss dec hex filename 152108 1184 24092 177384 2b4e8 stm32-netnsh-master 152168 1184 24092 177444 2b524 stm32-netnsh-this ``` On `stm32f4discovery:ipv6`, which uses `CONFIG_NET_IPv6`, the common code size increases 480 Bytes with `CONFIG_NETDEV_MULTIPLE_IPv6=n`, and increases 2KB if we enable this new feature `CONFIG_NETDEV_MULTIPLE_IPv6` and set `CONFIG_NETDEV_MAX_IPv6_ADDR` to 8. ``` > arm-none-eabi-size stm32-* text data bss dec hex filename 137346 1148 31332 169826 29762 stm32-ipv6-master 137826 1148 31332 170306 29942 stm32-ipv6-this-1addr 139402 1148 31572 172122 2a05a stm32-ipv6-this-8addr ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org