casaroli commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1400851199
########## arch/arm/src/Makefile: ########## @@ -18,7 +18,7 @@ # ############################################################################ -include $(TOPDIR)/Make.defs +include $(TOPDIR)/apps-or-nuttx-Make.defs Review Comment: but then it won't have included `nuttx/Make.defs`. The logic is "if there is `apps/Make.defs`, include it (which in turn includes `nuttx/Make.defs`, otherwise include `nuttx/Make.defs` directly" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
