casaroli commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1401677252
########## arch/arm/src/Makefile: ########## @@ -18,7 +18,7 @@ # ############################################################################ -include $(TOPDIR)/Make.defs +include $(TOPDIR)/apps-or-nuttx-Make.defs Review Comment: > Yes, you right. But can we do the trick inside Config.mk? I tried, however the arch Makefiles include directly `nuttx/Make.defs` -- the board `Make.defs`, (which will eventually include `Config.mk`) and then `apps/Make.defs` would be included after we have already included `nuttx/Make.defs` so it won't work :( Maybe a slightly cleaner solution is link the board `Make.defs` something else, like `nuttx/Board.defs` and then have this new file `apps-or-nuttx-Make.defs` be called `nuttx/Make.defs`, but this is essentially the same solution with better file naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
