This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 45315d78a1 Improved: Reduce the number of setMaxPriorityViolations 2
and 3 (OFBIZ-12814)
45315d78a1 is described below
commit 45315d78a16abf808341a6cb2a6f4cf452b6036d
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Wed Aug 30 11:16:43 2023 +0200
Improved: Reduce the number of setMaxPriorityViolations 2 and 3
(OFBIZ-12814)
Packages:
org.apache.ofbiz.accounting.invoice
org.apache.ofbiz.accounting.payment
---
.../org/apache/ofbiz/accounting/invoice/CreateApplicationList.groovy | 2 --
.../groovy/org/apache/ofbiz/accounting/invoice/EditInvoice.groovy | 5 ++---
.../apache/ofbiz/accounting/invoice/ListNotAppliedPayments.groovy | 1 -
.../groovy/org/apache/ofbiz/accounting/invoice/PrintInvoices.groovy | 5 ++---
.../org/apache/ofbiz/accounting/payment/BillingAccounts.groovy | 2 --
.../apache/ofbiz/accounting/payment/ListNotAppliedInvoices.groovy | 1 -
.../apache/ofbiz/accounting/payment/ListNotAppliedPayments.groovy | 1 -
7 files changed, 4 insertions(+), 13 deletions(-)
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/CreateApplicationList.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/CreateApplicationList.groovy
index fe92748f3f..f7749039ea 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/CreateApplicationList.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/CreateApplicationList.groovy
@@ -18,8 +18,6 @@
*/
package org.apache.ofbiz.accounting.invoice
-import org.apache.ofbiz.accounting.invoice.InvoiceWorker
-
import java.text.NumberFormat
// @param GenericValue invoice - The Invoice entity to find payment
applications for
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/EditInvoice.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/EditInvoice.groovy
index 0e0be3c909..5dd40e0d83 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/EditInvoice.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/EditInvoice.groovy
@@ -18,11 +18,10 @@
*/
package org.apache.ofbiz.accounting.invoice
-import org.apache.ofbiz.accounting.invoice.InvoiceWorker
-import org.apache.ofbiz.base.util.UtilNumber
-
import java.text.DateFormat
+import org.apache.ofbiz.base.util.UtilNumber
+
invoiceId = parameters.get('invoiceId')
invoice = from('Invoice').where('invoiceId', invoiceId).queryOne()
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/ListNotAppliedPayments.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/ListNotAppliedPayments.groovy
index 9cbfc710a9..80b2569a7f 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/ListNotAppliedPayments.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/ListNotAppliedPayments.groovy
@@ -18,7 +18,6 @@
*/
package org.apache.ofbiz.accounting.invoice
-import org.apache.ofbiz.accounting.invoice.InvoiceWorker
import org.apache.ofbiz.accounting.payment.PaymentWorker
import org.apache.ofbiz.base.util.UtilNumber
import org.apache.ofbiz.entity.condition.EntityConditionBuilder
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/PrintInvoices.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/PrintInvoices.groovy
index 90e1b61816..b9b93d1b24 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/PrintInvoices.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/PrintInvoices.groovy
@@ -18,11 +18,10 @@
*/
package org.apache.ofbiz.accounting.invoice
-import org.apache.ofbiz.accounting.invoice.InvoiceWorker
-import org.apache.ofbiz.base.util.UtilNumber
-
import java.text.DateFormat
+import org.apache.ofbiz.base.util.UtilNumber
+
invoiceDetailList = []
invoiceIds.each { invoiceId ->
invoicesMap = [:]
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/BillingAccounts.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/BillingAccounts.groovy
index c712d8151b..60d6c99bd8 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/BillingAccounts.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/BillingAccounts.groovy
@@ -18,8 +18,6 @@
*/
package org.apache.ofbiz.accounting.payment
-import org.apache.ofbiz.accounting.payment.BillingAccountWorker
-
partyId = parameters.partyId
currencyUomId = null
billingAccounts = []
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedInvoices.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedInvoices.groovy
index 0f76d9264c..417bb5e774 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedInvoices.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedInvoices.groovy
@@ -19,7 +19,6 @@
package org.apache.ofbiz.accounting.payment
import org.apache.ofbiz.accounting.invoice.InvoiceWorker
-import org.apache.ofbiz.accounting.payment.PaymentWorker
import org.apache.ofbiz.base.util.UtilNumber
import org.apache.ofbiz.entity.condition.EntityCondition
import org.apache.ofbiz.entity.condition.EntityOperator
diff --git
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedPayments.groovy
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedPayments.groovy
index 4941995be9..151eddfde2 100644
---
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedPayments.groovy
+++
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/ListNotAppliedPayments.groovy
@@ -18,7 +18,6 @@
*/
package org.apache.ofbiz.accounting.payment
-import org.apache.ofbiz.accounting.payment.PaymentWorker
import org.apache.ofbiz.base.util.UtilNumber
import org.apache.ofbiz.entity.condition.EntityCondition
import org.apache.ofbiz.entity.condition.EntityOperator
