[ofbiz-framework] branch trunk updated: Improved: Reduce the number of setMaxPriorityViolations 2 and 3 (OFBIZ-12814)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1cf51b41ad Improved: Reduce the number of setMaxPriorityViolations 2 
and 3 (OFBIZ-12814)
1cf51b41ad is described below

commit 1cf51b41ade83d14a6b8cb045b07e5e5a89eacb1
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Wed Aug 30 11:20:06 2023 +0200

    Improved: Reduce the number of setMaxPriorityViolations 2 and 3 
(OFBIZ-12814)
    
    Forgot to save PaymentServices.groovy in previous commit
    Reduces the number of setMaxPriorityViolations 2 and 3
---
 .../org/apache/ofbiz/accounting/payment/PaymentServices.groovy   | 9 ++++-----
 build.gradle                                                     | 4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/PaymentServices.groovy
 
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/PaymentServices.groovy
index 6662cdc8f3..11d3b3cd93 100644
--- 
a/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/PaymentServices.groovy
+++ 
b/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/payment/PaymentServices.groovy
@@ -18,23 +18,22 @@
 */
 package org.apache.ofbiz.accounting.payment
 
+import java.sql.Timestamp
+
 import org.apache.ofbiz.accounting.invoice.InvoiceWorker
-import org.apache.ofbiz.accounting.payment.PaymentWorker
+import org.apache.ofbiz.accounting.util.UtilAccounting
 import org.apache.ofbiz.base.util.UtilDateTime
 import org.apache.ofbiz.base.util.UtilFormatOut
 import org.apache.ofbiz.base.util.UtilMisc
 import org.apache.ofbiz.base.util.UtilProperties
+import org.apache.ofbiz.entity.GenericValue
 import org.apache.ofbiz.entity.condition.EntityCondition
 import org.apache.ofbiz.entity.condition.EntityConditionBuilder
 import org.apache.ofbiz.entity.condition.EntityOperator
-import org.apache.ofbiz.entity.GenericValue
 import org.apache.ofbiz.entity.util.EntityTypeUtil
 import org.apache.ofbiz.entity.util.EntityUtilProperties
 import org.apache.ofbiz.service.ServiceUtil
 
-import java.sql.Timestamp
-import org.apache.ofbiz.accounting.util.UtilAccounting
-
 Map createPayment() {
     if (!security.hasEntityPermission('ACCOUNTING', '_CREATE', 
parameters.userLogin) &&
             (!security.hasEntityPermission('PAY_INFO', '_CREATE', 
parameters.userLogin) &&
diff --git a/build.gradle b/build.gradle
index 2d7e2a6813..1c620bd171 100644
--- a/build.gradle
+++ b/build.gradle
@@ -395,8 +395,8 @@ gitHooks {
 codenarc {
     setConfigFile(new File('config/codenarc/codenarc.groovy'))
     setMaxPriority1Violations(0)
-    setMaxPriority2Violations(439)
-    setMaxPriority3Violations(4216)
+    setMaxPriority2Violations(410)
+    setMaxPriority3Violations(3979)
 }
 
 // Eclipse plugin settings