[
https://issues.apache.org/jira/browse/OODT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968600#action_12968600
]
Chris A. Mattmann commented on OODT-68:
---------------------------------------
Hi Brian:
I'm not sure I agree with this approach. It seems like the changing of an
interface that's been around for a long time w/o a real huge benefit. What is
the advantage of doing this over say, making getResultListSize public (which I
wouldn't necessarily agree with either, but just saying for posture).
Also let's be clear: how does this require DataSourceCatalog to do anything
special other than what it's always done? The types of calculations you're
speaking of (computing # of products) are typically computed in user-facing
code (either API-level callers of the pagniation API through fmClient, or
web-app consumers of the API looking to display this information on a result
set page) anyways, so they don't really impose anything on a specific Catalog
implementation (DataSource versus Lucene versus DbXML,etc.)
Cheers,
Chris
> Add Number of Product Hits to ProductPage
> -----------------------------------------
>
> Key: OODT-68
> URL: https://issues.apache.org/jira/browse/OODT-68
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
>
> - By adding get number of hits the method setTotalPages(int) is no longer
> needed; getTotalPages will calculate its return value based on page size and
> total hits
> - This also allows the number of products to be determined by just getting
> the first page, instead of getting last page which internally requires
> DataSourceCatalog to get first page and last page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
