[
https://issues.apache.org/jira/browse/OODT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969221#action_12969221
]
Chris A. Mattmann commented on OODT-68:
---------------------------------------
bq. let's say i leave setTotalPages(int) as is and just add
setNumberOfHits(int) and getNumberOfHits() . . . are we cool then?
Possibly, I'd need to see the approach taken in the patch.
bq. and actually . . . in order to get first page of a product type set and
number of products in that product type it currently causes 5 queries instead
of just one . . . getFirstPage(ProductType) requires two (one to get num of
hits and another to get products) . . .
Umm, let's be clear where these "queries" are occuring. Both the above 2 are
happening on the fm server end, close to the catalog implementation. So, they
aren't super expensive.
bq. getLastProductPage(ProductType) calls getFirstPage() and then gets products
for last page . . . if a query takes 20-30 seconds (typical for large data
sets)
Umm, by whose count is this _typical_? It sounds like an indexing issue to me
with the underlying database implementation. If a query is taking 20-30 seconds
to do a simple count then there's likely some _other_ issue here.
bq. that is then 5x30 which is a LONG time for a user to wait for a GUI to load
Agreed, but look at the bounds. 30 by itself is a *long* time to wait for the
GUi to load by itself? My feeling is that we could always create an alternative
DataSourceCatalog that implemented paging a different way if we had to deal
with these performance issues. I'd rather do this than change the *default
paging implementation* that's part of the actual architecture that's been
around since the fm inception. And yes, changing/adding/removing a field *is*
changing the architecture in some way.
> Add Number of Product Hits to ProductPage
> -----------------------------------------
>
> Key: OODT-68
> URL: https://issues.apache.org/jira/browse/OODT-68
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
>
> - By adding get number of hits the method setTotalPages(int) is no longer
> needed; getTotalPages will calculate its return value based on page size and
> total hits
> - This also allows the number of products to be determined by just getting
> the first page, instead of getting last page which internally requires
> DataSourceCatalog to get first page and last page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
