[
https://issues.apache.org/jira/browse/OODT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228152#comment-13228152
]
[email protected] commented on OODT-406:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4303/#review5867
-----------------------------------------------------------
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12784>
Great work!
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12785>
looks like just whitespace change, no biggie.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12786>
Interesting, is this extraneous or actually part of the patch?
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4303/#comment12787>
Interesting -- did this fix a bug in case actionIds was null?
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
<https://reviews.apache.org/r/4303/#comment12788>
extraneous?
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
<https://reviews.apache.org/r/4303/#comment12789>
Nice, way to indicate this.
- Chris
On 2012-03-13 01:31:24, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4303/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 01:31:24)
bq.
bq.
bq. Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Will introduce the reserved metadata field: PGETask_PropertyAdders and
deprecate: PGETask_PropertyAdderClasspath
bq.
bq.
bq. This addresses bug OODT-406.
bq. https://issues.apache.org/jira/browse/OODT-406
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
1298742
bq.
trunk/pge/src/test/org/apache/oodt/cas/pge/MockConfigFilePropertyAdder.java
PRE-CREATION
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4303/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit-tests
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Add CAS-PGE support for multiple Property Adders
> ------------------------------------------------
>
> Key: OODT-406
> URL: https://issues.apache.org/jira/browse/OODT-406
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-406.2012-03-12.patch.txt
>
>
> Will introduce the reserved metadata field: PGETask_PropertyAdders and
> deprecate: PGETask_PropertyAdderClasspath
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
