[
https://issues.apache.org/jira/browse/OODT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228237#comment-13228237
]
[email protected] commented on OODT-406:
----------------------------------------------------
bq. On 2012-03-13 02:37:18, Chris Mattmann wrote:
bq. > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java,
line 262
bq. > <https://reviews.apache.org/r/4303/diff/1/?file=91458#file91458line262>
bq. >
bq. > Interesting, is this extraneous or actually part of the patch?
i reformate the class... bad idea in hindsight... the only changes in this
class was the runPropertyAdders stuff and actionIds != null check
bq. On 2012-03-13 02:37:18, Chris Mattmann wrote:
bq. > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java,
line 433
bq. > <https://reviews.apache.org/r/4303/diff/1/?file=91458#file91458line433>
bq. >
bq. > Interesting -- did this fix a bug in case actionIds was null?
ya but not here directly... PgeMetadata's getAllMetadata was returning empty
list when it was supposed to return null when key didn't exist... realized this
when adding the multi property adders which was a multi value key.
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4303/#review5867
-----------------------------------------------------------
On 2012-03-13 01:31:24, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4303/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 01:31:24)
bq.
bq.
bq. Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Will introduce the reserved metadata field: PGETask_PropertyAdders and
deprecate: PGETask_PropertyAdderClasspath
bq.
bq.
bq. This addresses bug OODT-406.
bq. https://issues.apache.org/jira/browse/OODT-406
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java
1299921
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
1298742
bq.
trunk/pge/src/test/org/apache/oodt/cas/pge/MockConfigFilePropertyAdder.java
PRE-CREATION
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4303/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit-tests
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Add CAS-PGE support for multiple Property Adders
> ------------------------------------------------
>
> Key: OODT-406
> URL: https://issues.apache.org/jira/browse/OODT-406
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-406.2012-03-12.patch.txt
>
>
> Will introduce the reserved metadata field: PGETask_PropertyAdders and
> deprecate: PGETask_PropertyAdderClasspath
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
