[
https://issues.apache.org/jira/browse/OODT-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231377#comment-13231377
]
[email protected] commented on OODT-410:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4358/#review6043
-----------------------------------------------------------
./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
<https://reviews.apache.org/r/4358/#comment13016>
I think HsqlDbFriendlyDataSourceCatalog.paginateQuery was missing an "ORDER
BY ... DESC" clause here, whereas DataSourceCatalog (line 1960) does a
descending sort.
Since the primary key product_id is incremented (src/testdata/testcat.sql),
and "ShouldBeFirstForPage.txt" is inserted LAST, DataSourceCatalog returns
"ShouldBeFirstForPage.txt" as the first item on the FIRST page when ordered
DESC.
To me, it seems like DataSourceCatalog works properly and the test case
needs to be modified.
- Ricky
On 2012-03-16 14:14:17, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4358/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-16 14:14:17)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. DataSourceCatalog compatible with HypersonicSQL
bq.
bq.
bq. This addresses bug OODT-410.
bq. https://issues.apache.org/jira/browse/OODT-410
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java
1301321
bq.
./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
1301321
bq.
bq. Diff: https://reviews.apache.org/r/4358/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> DataSourceCatalog compatible with HypersonicSQL
> -----------------------------------------------
>
> Key: OODT-410
> URL: https://issues.apache.org/jira/browse/OODT-410
> Project: OODT
> Issue Type: New Feature
> Components: file manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
>
> This patch will provide a customizable extension of the DataSourceCatalog for
> use with HypersonicSQL DB. All of the existing DataSourceCatalog
> filemgr.properties config options will be reused.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
