[
https://issues.apache.org/jira/browse/OODT-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231497#comment-13231497
]
[email protected] commented on OODT-410:
----------------------------------------------------
bq. On 2012-03-16 16:52:35, Ricky Nguyen wrote:
bq. >
./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java,
line 769
bq. > <https://reviews.apache.org/r/4358/diff/2/?file=93070#file93070line769>
bq. >
bq. > I think HsqlDbFriendlyDataSourceCatalog.paginateQuery was missing an
"ORDER BY ... DESC" clause here, whereas DataSourceCatalog (line 1960) does a
descending sort.
bq. >
bq. > Since the primary key product_id is incremented
(src/testdata/testcat.sql), and "ShouldBeFirstForPage.txt" is inserted LAST,
DataSourceCatalog returns "ShouldBeFirstForPage.txt" as the first item on the
FIRST page when ordered DESC.
bq. >
bq. > To me, it seems like DataSourceCatalog works properly and the test
case needs to be modified.
I agree... it is a bad test... the test is checking that
ShouldBeFirstForPage.txt is the first product for the last page... and in the
test there are only 2 pages and the last page has only one product which makes
it the last product... whereas the test should be check that
ShouldBeFirstForPage.txt is the first product on the first page
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4358/#review6043
-----------------------------------------------------------
On 2012-03-16 14:14:17, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4358/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-16 14:14:17)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. DataSourceCatalog compatible with HypersonicSQL
bq.
bq.
bq. This addresses bug OODT-410.
bq. https://issues.apache.org/jira/browse/OODT-410
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java
1301321
bq.
./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
1301321
bq.
bq. Diff: https://reviews.apache.org/r/4358/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> DataSourceCatalog compatible with HypersonicSQL
> -----------------------------------------------
>
> Key: OODT-410
> URL: https://issues.apache.org/jira/browse/OODT-410
> Project: OODT
> Issue Type: New Feature
> Components: file manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
>
> This patch will provide a customizable extension of the DataSourceCatalog for
> use with HypersonicSQL DB. All of the existing DataSourceCatalog
> filemgr.properties config options will be reused.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
