Young-Flash commented on code in PR #2832:
URL:
https://github.com/apache/incubator-opendal/pull/2832#discussion_r1288546502
##########
bin/oay/src/services/webdav/webdavfs.rs:
##########
@@ -73,8 +75,96 @@ impl DavFileSystem for WebdavFs {
path: &'a dav_server::davpath::DavPath,
) -> dav_server::fs::FsFuture<Box<dyn dav_server::fs::DavMetaData>> {
async move {
- let opendal_metadata =
self.op.stat(path.as_url_string().as_str()).await.unwrap();
- Ok(Box::new(WebdavMetaData::new(opendal_metadata)) as Box<dyn
DavMetaData>)
+ let opendal_metadata =
self.op.stat(path.as_url_string().as_str()).await;
+ match opendal_metadata {
+ Ok(metadata) => {
+ let webdav_metadata = WebdavMetaData::new(metadata);
+ Ok(Box::new(webdav_metadata) as Box<dyn DavMetaData>)
+ }
+ Err(e) => Err(convert_error(e)),
+ }
+ }
+ .boxed()
+ }
+
+ fn create_dir<'a>(&'a self, path: &'a DavPath) ->
dav_server::fs::FsFuture<()> {
Review Comment:
If omit, here will raise error like " method was supposed to return data
with lifetime `'2` but it is returning data with lifetime `'1`", I know little
about lifetime hint 😂
##########
bin/oay/src/services/webdav/webdavfs.rs:
##########
@@ -73,8 +75,96 @@ impl DavFileSystem for WebdavFs {
path: &'a dav_server::davpath::DavPath,
) -> dav_server::fs::FsFuture<Box<dyn dav_server::fs::DavMetaData>> {
async move {
- let opendal_metadata =
self.op.stat(path.as_url_string().as_str()).await.unwrap();
- Ok(Box::new(WebdavMetaData::new(opendal_metadata)) as Box<dyn
DavMetaData>)
+ let opendal_metadata =
self.op.stat(path.as_url_string().as_str()).await;
+ match opendal_metadata {
+ Ok(metadata) => {
+ let webdav_metadata = WebdavMetaData::new(metadata);
+ Ok(Box::new(webdav_metadata) as Box<dyn DavMetaData>)
+ }
+ Err(e) => Err(convert_error(e)),
+ }
+ }
+ .boxed()
+ }
+
+ fn create_dir<'a>(&'a self, path: &'a DavPath) ->
dav_server::fs::FsFuture<()> {
Review Comment:
If omit, here will raise error like " method was supposed to return data
with lifetime `'2` but it is returning data with lifetime `'1`", I know little
about lifetime hint 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
