Young-Flash commented on code in PR #2832:
URL:
https://github.com/apache/incubator-opendal/pull/2832#discussion_r1288551886
##########
bin/oay/src/services/webdav/webdav_file.rs:
##########
@@ -83,7 +83,7 @@ impl DavFile for WebdavFile {
}
}
-fn convert_error(opendal_error: opendal::Error) -> dav_server::fs::FsError {
+pub fn convert_error(opendal_error: opendal::Error) -> dav_server::fs::FsError
{
Review Comment:
Implementing traits requires compliance with the Orphan Principle, seem oay
is not in the same crate as opendal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
